Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU3] Vertical staves adjustment and single line staves #7853

Merged

Conversation

njvdberg
Copy link
Contributor

@njvdberg njvdberg commented Mar 31, 2021

In VerticalGapData use SysStaff.bbox().y() for the Y-coordinate instead of SysStaff.y() when calculating the vertical position of the SysStaff because in case of single line staves, SysStaff.y() the returned value includes an offset. This resulted in wrong initial spacing between staves when one of the staves was a single line staff.
SysStaff.bbox().y() returns the uncorrected Y-coordinate which is required to calculate the correct spacing between staves.

PR #7854 is a similar PR for master.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

…ad of

SysStaff.y() when calculating the vertical position of the SysStaff because
in case of single line staves, SysStaff.y() the returned value includes
an offset. This resulted in wrong initial spacing between staves when one
of the staves was a single line staff.
SysStaff.bbox().y() returns the uncorrected Y-coordinate which is required
to calculate the correct spacing between staves.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants